feat: support shareProcessNamespace is pod.spec #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmith3197
suggested changes
Sep 8, 2023
Additionally, move the `shareProcessNamespaces` in the `_pod.tpl`, before `dnsPolicy`, to keep dns values together in the template.
andresperezl
force-pushed
the
share-process-namespace
branch
from
aec9acf
to
b56de88
Compare
dsmith3197
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set the
pod.spec.shareProcessNamespacevalue in the pod template (defaults tofalse), which allows the sidecars container to be able to send the reload signal (SIGHUP) to the vector process.